chore: pcre2 10.43 -> 10.47#1166
Open
mcoliver wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Open
chore: pcre2 10.43 -> 10.47#1166mcoliver wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
mcoliver wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Numerous bug fixes and improvements https://github.com/PCRE2Project/pcre2/blob/pcre2-10.47/ChangeLog PCRE2Project/pcre2@pcre2-10.43...pcre2-10.47 Signed-off-by: Michael Oliver <mcoliver@gmail.com>
updated hash to be accurate Signed-off-by: Michael Oliver <mcoliver@gmail.com>
mcoliver
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
cedrik-fuoco-adsk
approved these changes
Mar 19, 2026
|
|
||
| SET(_download_url | ||
| "https://github.com/PCRE2Project/pcre2/archive/refs/tags/${_version}.zip" | ||
| "https://github.com/PCRE2Project/pcre2/archive/refs/tags/${_version}.tar.gz" |
Contributor
There was a problem hiding this comment.
The .zip are available still. Was there a particular reason for the change?
Contributor
Author
There was a problem hiding this comment.
Zip and Tar seemed to be used about equally in this project (see below). However zip is slightly larger (arguably negligible for most projects with todays infra) so downloads are slightly slower and use more bandwidth. I thought I noticed more of the recent changes tended to be tar.gz so I was attempting to standardize on that.
I don't really care but it was more of my OCD on trying to standardize on a certain filetype. If you have a preference please let me know.
rel (.venv) ➜ /Users/moliver/dev/_openrv/OpenRV/cmake/dependencies git:(oiio3) grep github.com | grep tar | sort | uniq
doctest.cmake: "https://github.com/doctest/doctest/archive/refs/tags/v${_version}.tar.gz"
expat.cmake: "https://github.com/libexpat/libexpat/archive/refs/tags/R_${_version_underscored}.tar.gz"
glew.cmake: "https://github.com/nigels-com/glew/archive/refs/tags/glew-${_version}.tar.gz"
jpegturbo.cmake: "https://github.com/libjpeg-turbo/libjpeg-turbo/archive/refs/tags/${_version}.tar.gz"
oiio.cmake: "https://github.com/AcademySoftwareFoundation/OpenImageIO/archive/refs/tags/v${_version}.tar.gz"
openjpeg.cmake: "https://github.com/uclouvain/openjpeg/archive/refs/tags/v${_version}.tar.gz"
openjph.cmake: "https://github.com/aous72/OpenJPH/archive/refs/tags/${_version}.tar.gz"
openssl.cmake: "https://github.com/openssl/openssl/releases/download/OpenSSL_${_version_underscored}/openssl-${_version}.tar.gz"
openssl.cmake: "https://github.com/openssl/openssl/releases/download/openssl-${_version}/openssl-${_version}.tar.gz"
png.cmake: "https://github.com/glennrp/libpng/archive/refs/tags/v${_version}.tar.gz"
raw.cmake: "https://github.com/LibRaw/LibRaw/archive/refs/tags/${_version}.tar.gz"
webp.cmake: "https://github.com/webmproject/libwebp/archive/refs/tags/v${_version}.tar.gz"
rel (.venv) ➜ /Users/moliver/dev/_openrv/OpenRV/cmake/dependencies git:(oiio3) grep github.com | grep tar | sort | uniq | wc -l
12
rel (.venv) ➜ /Users/moliver/dev/_openrv/OpenRV/cmake/dependencies git:(oiio3) grep github.com | grep zip | sort | uniq
aja.cmake: "https://github.com/aja-video/libajantv2/archive/refs/tags/ntv2_${_version_with_underscore}.zip"
atomic_ops.cmake: "https://github.com/ivmai/libatomic_ops/archive/044573903530c4a8e8318e20a830d4a0531b2035.zip"
dav1d.cmake: "https://github.com/videolan/dav1d/archive/refs/tags/${_version}.zip"
ffmpeg.cmake: "https://github.com/FFmpeg/FFmpeg/archive/refs/tags/${_version}.zip"
gc.cmake: "https://github.com/ivmai/bdwgc/archive/refs/tags/v${_version}.zip"
imath.cmake: "https://github.com/AcademySoftwareFoundation/Imath/archive/refs/tags/v${_version}.zip"
imgui.cmake: "https://github.com/pthom/imgui/archive/refs/tags/${_version}.zip"
ocio.cmake: "https://github.com/AcademySoftwareFoundation/OpenColorIO/archive/refs/tags/v${_version}.zip"
openexr.cmake: URL "https://github.com/AcademySoftwareFoundation/openexr/archive/refs/tags/v${_version}.zip"
pcre2.cmake: "https://github.com/PCRE2Project/pcre2/archive/refs/tags/${_version}.zip"
python3.cmake: "https://github.com/python/cpython/archive/refs/tags/v${_python3_version}.zip"
spdlog.cmake: "https://github.com/gabime/spdlog/archive/refs/tags/v${_version}.zip"
zlib.cmake: "https://github.com/madler/zlib/archive/refs/tags/v${_version}.zip"
rel (.venv) ➜ /Users/moliver/dev/_openrv/OpenRV/cmake/dependencies git:(oiio3) grep github.com | grep zip | sort | uniq | wc -l
13
rel (.venv) ➜ /Users/moliver/dev/_openrv/OpenRV/cmake/dependencies git:(oiio3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1104
Linked issues
Summarize your change.
Describe the reason for the change.
Describe what you have tested and on which operating system.
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.